search

Murali-group / GraphSpace

The interactive graph sharing website.
http://graphspace.org
GNU General Public License v2.0
30 stars 41 forks source link

Fixes issue #262 added Save button to graph layout editor #271

Open melvin15may opened 7 years ago

melvin15may commented 7 years ago

Fixes issue #262 Added save button with its own dedicated modal.

Screenshot of layout editor before this PR BEFORE

Screenshot of layout editor after this PR AFTER

Screenshot of Save dialog Save dialog modal

jlaw9 commented 7 years ago

The current title of "Save Layout" leads users to believe they are saving the layout of the nodes (x and y positions) rather than the x and y positions and the style of every node which leads to issues like #310. I suggest we change the save popup title to "Save Layout and Style" or add a description in the popup saying something like "Current x and y positions of nodes as well as style attributes of every node and edge will be saved"

tmmurali commented 7 years ago

I suggest "Save Positions and Style" and to change the voice of the pop-up to active: "Save the current x- and y-coordinates of every node and the style attributes of every node and edge."

On Tue, Aug 22, 2017 at 9:21 AM, Jeff Law notifications@github.com wrote:

The current title of "Save Layout" leads users to believe they are saving the layout of the nodes (x and y positions) rather than the x and y positions and the style of every node which leads to issues like #310 https://github.com/Murali-group/GraphSpace/issues/310. I suggest we change the save popup title to "Save Layout and Style" or add a description in the popup saying something like "Current x and y positions of nodes as well as style attributes of every node and edge will be saved"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Murali-group/GraphSpace/pull/271#issuecomment-324024051, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkWUJ3EHzjkF5RWSjXD64wzaAdrpwILks5satXggaJpZM4NsKob .