search

Murali-group / GraphSpace

The interactive graph sharing website.
http://graphspace.org
GNU General Public License v2.0
30 stars 41 forks source link

UI of Export button on Graphs page behaves abnormally #343

Closed jahandaniyal closed 3 years ago

jahandaniyal commented 6 years ago

This is a minor bug and doesn't affect the functionality of Graphspace in any way. Bug : Export button is always at the top because of an unusually high z-index value of 20000. The problem is that when the user wants to sign-out the export button hides the sign-out drop-down menu. Also, while scrolling down, export button goes above the main header of the page. I believe the z-index was set to make sure Export Dropdown menu does not get hidden by the Graph Visualisation Canvas.

Resolution : Setting z-index to 1001 fixes the the issue.

current div : <div class="btn-group pull-right" style="margin-right: 1em !important; z-index: 20000"> proposed change : <div class="btn-group pull-right" style="margin-right: 1em !important; z-index: 1001">

adbharadwaj commented 6 years ago

@jahandaniyal can you fix this and send a pull request.

tmmurali commented 6 years ago

Is there a way to fix this issue without hardcoding a z-index value?

On Wed, Feb 7, 2018 at 1:50 PM, Aditya Bharadwaj notifications@github.com wrote:

@jahandaniyal https://github.com/jahandaniyal can you fix this and send a pull request.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Murali-group/GraphSpace/issues/343#issuecomment-363870886, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkWUKOahqQON3GJEGEhPG7nDNt5_VRQks5tSfCFgaJpZM4R5KEM .

adbharadwaj commented 6 years ago

@tmmurali I dont think there is a way to fix it without hardcoding z-index value.

tmmurali commented 6 years ago

OK. Thanks.

On Sat, Feb 10, 2018 at 11:06 PM, Aditya Bharadwaj <notifications@github.com

wrote:

@tmmurali https://github.com/tmmurali I dont think there is a way to fix it without hardcoding z-index value.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Murali-group/GraphSpace/issues/343#issuecomment-364719000, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkWUMxbXAiKNZgljKH4u-IyIcZNaXjvks5tTmc9gaJpZM4R5KEM .