search

Murali-group / GraphSpace

The interactive graph sharing website.
http://graphspace.org
GNU General Public License v2.0
30 stars 41 forks source link

Validates email address by sending a confirmation email to users #368

Open lohani2280 opened 6 years ago

lohani2280 commented 6 years ago

In order to validate the email address of the user provided during registration, a confirmation email with activation link is sent to the email address and when the user clicks the link, the email address is verified and the account gets activated.

I have added a gif below showing the changes- send_email_confirmation

fixes https://github.com/Murali-group/GraphSpace/issues/360

lohani2280 commented 6 years ago

@adbharadwaj, @tmmurali Sir, I have added gif for this feature as well. Please have a look at it once.

adbharadwaj commented 6 years ago

@lohani2280 a few comments

tmmurali commented 6 years ago

"Please verify your account in order to ..." is vague. It will not be clear to the user what they need to do in order to verify the account or even what verify the account means. We have to say something along the lines of "Please check your inbox for an email message from GraphSpace that will contain an URL that you should visit in order to verify your email address."

We also need to think about what to do if the user has not received the email message or deleted it. Should we add an option to resend the message?

On Sat, Mar 3, 2018 at 8:22 PM, Aditya Bharadwaj notifications@github.com wrote:

@lohani2280 https://github.com/lohani2280 a few comments

  • We may want a proper error message instead of User not verified. We can say - "Please verify your account in order to log in to GraphSpace." Can you find out what is the language used by other websites?
  • Can you find out what is the content of the verification email sent by other websites?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Murali-group/GraphSpace/pull/368#issuecomment-370193940, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkWUPNv2NR1SRHxKMP6UIjUQqm1VzcFks5ta0HTgaJpZM4SRdik .

lohani2280 commented 6 years ago

@adbharadwaj, @tmmurali Sir, I just checked out my email and found a few emails to verify my account. I have listed them in this GitHubGist. Please have a look at it.

I think a content as follows would be appropriate for us-

Congratulations! Your GraphSpace account is almost ready, but before you can login you need to complete a brief account verification process.

**Click here** to verify your email ID.

On successfully completing this verification, your GraphSpace account will be activated.

Thanks, 
GraphSpace
lohani2280 commented 6 years ago

@tmmurali Sir, I am working on adding an option to resend the message and I will update you very soon.

lohani2280 commented 6 years ago

Ping @tmmurali @adbharadwaj

lohani2280 commented 6 years ago

@adbharadwaj @tmmurali I have resumed the work over this PR.It would be really helpful if you would comment regarding the content of the email to be sent to the user account.

adbharadwaj commented 6 years ago

@lohani2280 Can you do a background research in what content is usually used for such email by different websites?

lohani2280 commented 6 years ago

@adbharadwaj I have actually done some research over the content. I have listed them in this GitHubGist. Please have a look at it.