Added a Save Layout button on the Layouts pane

Murali-group / GraphSpace

The interactive graph sharing website.

http://graphspace.org

GNU General Public License v2.0

30 stars 41 forks source link

Added a Save Layout button on the Layouts pane #411

Closed lohani2280 closed 5 years ago

lohani2280 commented 5 years ago

Purpose

Adding a "Save Layout" button on the Layouts pane

Fixes https://github.com/Murali-group/GraphSpace/issues/392

In the gif below, I have tried to demonstrate the above solution best

Approach

On pressing the "Save Layout" button, a dialogue box asking to save the layout pops up and the user can now directly save the layout generated without entering the Layout Editor and immediately exiting out.

Open Questions and Pre-Merge TODOs

[ ] Use github checklists. When solved, check the box and explain the answer.

lohani2280 commented 5 years ago

Ping @adbharadwaj @jlaw9

jlaw9 commented 5 years ago

Looks great to me.

Can you change the title of the layout pop-up to "Save Positions and Style" and add the description "Save the current x- and y-coordinates of every node and the style attributes of every node and edge." to the pop-up? This is from #271

lohani2280 commented 5 years ago

@jlaw9 Thanks for the review. I'll update my PR soon.

lohani2280 commented 5 years ago

@jlaw9 Updated the PR as suggested. I have also attached the screenshot of the layout pop-up. Please have a look.

screenshot from 2019-01-26 00-07-46

jlaw9 commented 5 years ago

Thanks looks good. Ideally this button would be able to save just the x- and y-coordinates as that's all you can change in this mode, but I think that can wait for a different issue.

lohani2280 commented 5 years ago

Exactly. Even I was thinking that in this mode one can only save the x-and y-coordinates and not the styles.