search

Murali-group / halp

Hypergraph Algorithms Package
GNU General Public License v3.0
95 stars 21 forks source link

python 2.6 compatibility: 2.6 doesn't support set literals #6

Closed tylerkahn closed 10 years ago

tylerkahn commented 10 years ago

In python 2.7+ you can do {2, 3} to represent set([2, 3]). That syntax isn't supported in 2.6.

We use that syntax in our tests.

https://github.com/tmmurali/hypergraph/blob/master/tests/test_read_hypergraphs.py#L16

Do we want to maintain 2.6 compatibility?

doaa-altarawy commented 10 years ago

In my opinion, no we shouldn't. If we keep leaving incomparable features in python3, we will end up not using many of its new powerful features. We can require Python3. I find packages do that.

This is my opinion

tylerkahn commented 10 years ago

For what it's worth, we have Python 3 and 2.7 compatibility at this point.

tylerkahn commented 10 years ago

Closed with pull request #7