MuraliKola / robotframework-seleniumlibrary

Automatically exported from code.google.com/p/robotframework-seleniumlibrary
Apache License 2.0
1 stars 0 forks source link

addCustomRequestHeaders doesn't work #243

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
With current version command:
selenium.addCustomRequestHeaders doesn't work - it does return success but is 
ineffective - user specified headers are not added to requests. Selenium server 
is missing parameter addCustomRequestHeaders=true when initializing new session.

Proposed patch:

--- selenium.py 2012-03-19 19:57:19.000000000 +0100
+++ selenium.py 2012-06-21 16:02:41.666887363 +0200
@@ -186,7 +186,6 @@
         start_args = [self.browserStartCommand, self.browserURL, self.extensionJs]
         if browserConfigurationOptions:
           start_args.append(browserConfigurationOptions)
-        start_args.append("addCustomRequestHeaders=true")
         result = self.get_string("getNewBrowserSession", start_args)
         try:
             self.sessionId = result

Original issue reported on code.google.com by chmielss...@gmail.com on 21 Jun 2012 at 2:14

GoogleCodeExporter commented 8 years ago
Of course patch above is reversed - simple mistake.

Original comment by chmielss...@gmail.com on 25 Jun 2012 at 3:00

GoogleCodeExporter commented 8 years ago

Original comment by janne.t....@gmail.com on 6 Aug 2012 at 10:45

GoogleCodeExporter commented 8 years ago
This issue was updated by revision 6ec1a4cb0bf2.

Original comment by janne.t....@gmail.com on 6 Aug 2012 at 10:59

GoogleCodeExporter commented 8 years ago

Original comment by janne.t....@gmail.com on 27 Aug 2012 at 1:08