highlightjs dependency removed from ngx-highlight.js?

rajeshtarte commented 4 months ago

Removed dependency from ngx-hjightjs?

"dependencies": { "highlight.js": "^11.5.1", "highlightjs-line-numbers.js": "^2.8.0", "tslib": "^2.0.0" },

Bug Report or Feature Request (mark with an `x`)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] question

OS and Version?

Versions

Repro steps

The log given by the failure

Desired functionality

Mention any other details that might be useful

MurhafSousli commented 4 months ago

No it was not removed! what is your issue?

rajeshtarte commented 4 months ago

Hi MurhafSousli, thanks for replying back to me

Issue was I followed instructions . but it actually imported alpha version 11.xxx when i checked its package.json file hightlight.js and other dependencies were not there then I used laser version like 10.0.0 , which has highlight.js though still missing few others but atleat now i got hightlight.ts

one more thing for typescript file sometimes it shows Component as keyworrd and sometimes not

Regards Rajesh

On Sun, 12 May, 2024, 21:32 Murhaf Sousli, @.***> wrote:

No it was not removed! what is your issue?

— Reply to this email directly, view it on GitHub https://github.com/MurhafSousli/ngx-highlightjs/issues/283#issuecomment-2106299861, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKLKYE2TQNV54BHQZX46DXLZB6HA5AVCNFSM6AAAAABHSRT5JKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGI4TSOBWGE . You are receiving this because you authored the thread.Message ID: @.***>

Jonesmann1337 commented 3 months ago

No it was not removed! what is your issue?

Actually it really was removed and I highly recommend to add it back to the project's package.json, otherwise we have to manually install this dependency on our own, which doesn't make much sense IMHO.

See diff

MurhafSousli / ngx-highlightjs