search

MurhafSousli / ngx-scrollbar

Custom overlay-scrollbars with native scrolling mechanism
https://ngx-scrollbar.netlify.app/
MIT License
611 stars 99 forks source link

No code sample for scroll events #640

Closed sharathdaniel closed 1 month ago

sharathdaniel commented 1 month ago

Documentation Feedback

I don't see any code sample for scroll events like top reached, bottom reached etc. Even the stackblitz example is not having anything.

How would someone understand to implement these events without even a mention in the documentation.

EDIT: Is this the link to events documentation? I had to expand the pages menu in the sidebar, This can be missed way easily. Also where is the doc for dropped events?

IMO the below section in the Wiki home page should have links. image

MurhafSousli commented 1 month ago

No, that link is for the older version (v13), but it is almost the same usage. I will add guide for the reached / dropped events soon.

MurhafSousli commented 1 month ago

Added Reached & Dropped Events docs

sharathdaniel commented 4 weeks ago

@MurhafSousli Is this correct or did you meant NgScrollReached? (in the import statement)

image

MurhafSousli commented 4 weeks ago

Yea, need to correct it

sharathdaniel commented 3 weeks ago

@MurhafSousli Sorry to bother you again. The below entire line is missing from the documentation of events. Its present in the legacy events example.

import { NgScrollReached, NgScrollDropped } from 'ngx-scrollbar/reached-event';

MurhafSousli commented 3 weeks ago

Added the imports lines