MurhafSousli / ngx-sharebuttons

Angular Share Buttons ☂
https://ngx-sharebuttons.netlify.app/
MIT License
527 stars 127 forks source link

console errors #443

Closed dawa-liverpudlian closed 4 years ago

dawa-liverpudlian commented 4 years ago

1 ) FontAwesome: Global icon library is deprecated. Consult https://github.com/FortAwesome/angular-fontawesome/blob/master/UPGRADING.md for the migration instructions.

2) ERROR TypeError: Cannot read property 'create' of undefined at ShareDirective._createShareButton (ngx-share-core.js:1658) Can you please look at this issue.

Although doesn't affect the flow.

MurhafSousli commented 4 years ago

Please check for existing issues before opening a new one. this has been solved in v8

432 , demo: https://stackblitz.com/edit/ngx-sharebuttons-v8

dawa-liverpudlian commented 4 years ago

Ahh, sorry forgot to check the closed issue's. Thank you for the help. No errors now.

Thanks.

On Sat, Apr 25, 2020 at 8:22 AM Murhaf Sousli notifications@github.com wrote:

Please check for existing issues before opening a new one. this has been solved in v8

432 https://github.com/MurhafSousli/ngx-sharebuttons/pull/432 , demo:

https://stackblitz.com/edit/ngx-sharebuttons-v8

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MurhafSousli/ngx-sharebuttons/issues/443#issuecomment-619305604, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRHVCMWGF2HWMOZ5VPKS6TROJCMRANCNFSM4MQASFDQ .

dawa-liverpudlian commented 4 years ago

Please check for existing issues before opening a new one. this has been solved in v8

432 , demo: https://stackblitz.com/edit/ngx-sharebuttons-v8

Do we need to use angular 9 with the version 8.0.0-beta.1 ? It's working fine locally but when i build i am getting error.

MurhafSousli commented 4 years ago

I am not 100% sure! I don't get the chance to build and test with multiple angular versions.. so I rely on users feedback. if you are positive that the build error is caused by the share buttons then it means you need to upgrade to NG9 or stick to the previous version. :)