MurhafSousli / ngx-sharebuttons

Angular Share Buttons ☂
https://ngx-sharebuttons.netlify.app/
MIT License
527 stars 126 forks source link

Issue with ngx- popup #516

Closed Alsmith141510 closed 3 years ago

Alsmith141510 commented 3 years ago

I am submitting a

What is the expected behavior?

I am facing two issues 1) When using the popup button.

IT errors out stating that it could not find share image. I believe the share icon is not part of your package. 2) When using the include option. the component is putting in the URL: over the share. There is no way to remove it. In my development environment even though I give the URL for my prod site it displays localhost. #### What is the current behavior? 1) doesn't work. 2) I am trying to use the popup button. I can bring up the modal window. but on the top as indicated in the picture along with the word 'Share'. has the 'localhost. '. I have tried everything to suppress it but have been unsuccessful. #### What are the steps to reproduce? ![sharebutton_err](https://user-images.githubusercontent.com/39094436/101995877-5646a580-3c9b-11eb-902d-0a7a899d55aa.JPG) setup Ngx-sharebutton with popup. #### What is the use-case or motivation for changing an existing behavior? I have gotten around first issue with using 2) On the second issue I have taken out the complete [exclude] option so I am good now but it is prickly. took a while to figure out. #### Which versions are you using for the following packages? Angular: 10.0.5 Angular CDK: 10.1.0 Angular CLI: 10.0.4 Angular-fontawesome: "@fortawesome/angular-fontawesome": "0.8.0", "@fortawesome/fontawesome-svg-core": "1.2.32", "@fortawesome/free-brands-svg-icons": "5.15.1", "@fortawesome/free-solid-svg-icons": "5.15.1" ngx-sharebuttons: 8.0.4 #### Is there anything else we should know? I have gotten around first issue with using 2) On the second issue I have taken out the complete [exclude] option so I am good now but it is prickly. took a while to figure out.
MurhafSousli commented 3 years ago

The pop up component is still not completed, I haven't got the time to finalize it, so you may want to adjust the css manually if you are using the circle buttons