MurhafSousli / ngx-sharebuttons

Angular Share Buttons ☂
https://ngx-sharebuttons.netlify.app/
MIT License
527 stars 127 forks source link

Tweniee:#650 Added X Twitter icon #655

Closed Tweniee closed 4 months ago

Tweniee commented 10 months ago

@MurhafSousli Please can you review #650 image

mikecci commented 10 months ago

Any idea when the pull request will be reviewed?

mikecci commented 9 months ago

@MurhafSousli

MurhafSousli commented 9 months ago

@mikecci Why don't we just change the existing twitter button icon?

Tweniee commented 9 months ago

@mikecci Why don't we just change the existing twitter button icon?

It good to have options and diversity

MurhafSousli commented 9 months ago

@Tweniee I don't think users would use the old twitter icon when the new one is available!

Tweniee commented 9 months ago

@MurhafSousli I believe there should be an option for end users to choose their preferred icon. This way, users can align the icon with their chosen theme. Many web apps currently use the old logo to match their themes, and newly created logos can be applied to new web apps also.

Tweniee commented 9 months ago

@Tweniee Users might not opt for the old Twitter icon if the new one is accessible!

I share your perspective, but I believe there should be room for flexibility without removing already established logos. For instance, the IRCTC website, which handles a significant database, continues to use the old bird logo from Twitter as an example.

Screenshot Capture - 2023-12-15 - 18-30-17

AshotAleqsanyan96 commented 8 months ago

Hello Friends, I would like to know when are you planning to merge this pull request and publish a new version of library?

MurhafSousli commented 8 months ago

I cannot merge this PR, I requested a change, we don't want 2 twitter buttons with different icons, users can always change the icon of the button if they like, but we should not have two duplicated buttons with only icon difference.

AshotAleqsanyan96 commented 8 months ago

@MurhafSousli thank you very much for the quick reply and clarification. yeah we will process with your suggestion

MurhafSousli commented 4 months ago

This is fixed in v14 beta