search

MurhafSousli / ngx-sharebuttons

Angular Share Buttons ☂
https://ngx-sharebuttons.netlify.app/
MIT License
527 stars 127 forks source link

fix(#662): linkedin share button, to be able to share button description as ?text= #663

Closed mfenderov closed 5 months ago

mfenderov commented 5 months ago

Fix to the https://github.com/MurhafSousli/ngx-sharebuttons/issues/662

MurhafSousli commented 5 months ago

Nope, that issue cannot be fixed because linkedin ignores the description. where did you get this from?

mfenderov commented 5 months ago

I've tried it on my website and it works with this fix. For example, https://www.linkedin.com/shareArticle?mini=true&url=google.com&text=hello,world

MurhafSousli commented 5 months ago

I've tried it on my website and it works with this fix. For example, https://www.linkedin.com/shareArticle?mini=true&url=google.com&text=hello,world

But this does not show "hello world" as description, can you show a screenshot?

mfenderov commented 5 months ago

I've tried it on my website and it works with this fix. For example, https://www.linkedin.com/shareArticle?mini=true&url=google.com&text=hello,world

But this does not show "hello world" as description, can you show a screenshot?

I guess there's a misunderstanding from my side. I thought the purpose of this attribute was to pass a text to a post. Or is it about the OpenGraph metadata?

MurhafSousli commented 5 months ago

It's about LinkedIn that only accepts the url as a parameter, the rest of the properties are fetched from the meta tags

mfenderov commented 5 months ago

It's about LinkedIn that only accepts the url as a parameter, the rest of the properties are fetched from the meta tags

This is not true: text is also accepted as a query parameter, but, as I've tested it just now, only for the desktop 🤷