search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.49k stars 110 forks source link

Differentiate icons between GitLab instances #10

Open JulianGro opened 2 years ago

JulianGro commented 2 years ago

Currently all GitLab instances share the same icon. It can be a pretty normal thing for some users to use multiple GitLab instances, which are annoying to differentiate in Gittyup. I would suggest that we look at the GitLab instance URLs and choose a more appropriate icon if available. For example, I am on GitLab, on the KDE Gitlab instance, on the Gnome GitLab instance, on the Debian GitLab instance, and on the Alpine Linux GitLab instance. We could either grab their favicons, or add logic for Gittyup for looking if icons are available, and then we could manually add them. All of the instances that I checked actually have slightly or even very oversized favicons, so they would be an option even on high-dpi displays.

Murmele commented 2 years ago

Yes thats a good idea

Murmele commented 2 years ago

So maybe storing them local in a lookup table. So it is possible even when working offline and as soon as the instance is online it fetches again (maybe also only once per day)

RokeJulianLockhart commented 1 year ago

@Murmele, it should just fetch them upon initialization asynchronously.