search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.42k stars 107 forks source link

UI doesn't automatically refresh changes #216

Open ruiznick opened 2 years ago

ruiznick commented 2 years ago

OS: Linux Mint 19.3 Cinnamon App Version: 1.1.1 flatpak

Making changes such as editing/adding/renaming files doesn't automatically appear in the UI. The UI only updates when manually clicking View -> Refresh.

I couldn't find the issue here but might have found something similar in gitahead https://github.com/gitahead/gitahead/issues/318#issue-523909985

Murmele commented 1 year ago

Hi @ruiznick thanks for pointing to the issue! We have to distinguish: 1) Editing file locally 2) Editing the git history by another application or the git command line

In the linked issue they are talking about the second point. Are you refering to the first point?

I have seen this behaviour on hidden files. There I have to refresh manually. For normal files the gui shall be refreshed automatically.

lonix1 commented 1 year ago

Yes. Many people use git in the terminal and IDE (e.g. vscode) as well as a dedicated git GUI (like gittyup).

When I do any branching, stashing, committing, etc., and then switch back to gittyup, the changes are not shown until I refresh.

In other guis - e.g. vscode, gitkraken, sourcetree - when the window regains focus, it automatically refreshes. Maybe gittyup could do that too?

ruiznick commented 1 year ago

Hi @ruiznick thanks for pointing to the issue! We have to distinguish:

1. Editing file locally

2. Editing the git history by another application or the git command line

In the linked issue they are talking about the second point. Are you refering to the first point?

I have seen this behaviour on hidden files. There I have to refresh manually. For normal files the gui shall be refreshed automatically.

@Murmele If I make a change in JetBrains Rider and switch to Gittyup the changes do appear to load reliably. But if I make changes in Unity and alter a scene file (.unity file extension) then Gittyup doesn't auto refresh.

Murmele commented 1 year ago

We are using a Repositiory watcher to check if we have local changes. Currently we are ignoring all .* files / folders. This behaviour comes from GitAhead and we did not touch it yet.

const QDir::Filters kFilters = (QDir::Dirs | QDir::NoDotAndDotDot); in RepositoryWatcher_linux.cpp on mac and windows it looks different.

Even for branch changes we don't detect them for this we would have to watch on .git/HEAD

ruiznick commented 1 year ago

I should clarify, I meant Filename.unity files and not dot files.

Murmele commented 1 year ago

hmm ok then it is a bug ^^

Murmele commented 1 year ago

@ruiznick is this still reproducable? can you provide me two examples of such a .unity file? So I can test the behaviour

Pictor13 commented 1 year ago

Most (or all?) git operations performed outside of Gittyup won't be detected. Also in my case I have to remember to refresh with CTRL+R.

Examples are: to reset a branch to another commit; or pushing a new commit to remote.

Murmele commented 1 year ago

Can you open for this an issue, because this is not yet implemented. Only changes in the working directory are considered