Add display options to the commit list

[Nico-Duduf]

Options to show/hide:

• Author
• Date
• Id

in the commit list, as discussed in #487

[Nico-Duduf]

The options:

Examples:

Compact without details:

Compact with author:

Standard with just the date:

Standard without author:

etc etc. ;)

I had a bit of trouble finding the best way to adjust the layout in non-compact mode according to the options...

[mahomedh]

This looks great. Could I make a suggestion though? In the Compact with author: screenshot, you have the author name at the beginning of the message. This is fine if you are somehow modifying the name to workout just the first name. If not, the info would be better in its own column. In our case, the Author/Commiter is the person's full name and their email address. So a resizable column will more useful (though granted atm the date and Id are not resizable columns).

[Nico-Duduf]

the Author/Commiter is the person's full name and their email address.

I'm not sure I understand; in Gittyup only the author name is shown as in my screenshot. Maybe you mean that in your case the actual author name contains both a full name and email adress? Of course this is going to take a lot of room, and I'll think you'll have issues everwhere not only in Gittyup ;)

So a resizable column will more useful (though granted atm the date and Id are not resizable columns).

The problem is that this is a listview, and it's a single-column widget without headers. It would be much more work to adapt it to a multi-column widget, and that would be a different feature to implement. In my experience, multi column lists introduce more problems than they solve, especially with resizable columns. Unless you actually need a table, I'm not sure this is a path to follow... At least, I won't be the one to follow it for a simple list like this one ;)

[mahomedh]

I'm not sure I understand; in Gittyup only the author name is shown as in my screenshot. Maybe you mean that in your case the actual author name contains both a full name and email adress?

Yes, that's right. We use the person's full name, and it adds the email address as well. I understand that adding resizeable columns would be a big change. My point is to maybe add the name next to the current "columns" of Id and Date, rather than at the beginning of the commit message. That way the name length won't matter too much and it won't be too much of a visual change for users who are used to seeing the commit message first.

But that's just my suggestion. Either way, your change is an improvement, and thanks for implementing it.

[Nico-Duduf]

add the name next to the current "columns" of Id and Date

I really don't mind having it on the left or on the right, the decision is up to @Murmele ;)

[Murmele]

add the name next to the current "columns" of Id and Date

I really don't mind having it on the left or on the right, the decision is up to @Murmele ;)

I think the question is, if the commit message or the author is more important. If the commit message will be long, the author might not be visible anymore unless we limit the number of characters of the commit message.

Another point. Might it worth creating the checkbox for the author twice to get the old behaviour? So having an author compact (default false) and author normal (default true)?

[Murmele]

@Nico-Duduf Please format the code. In the repository there is the cl-fmt.sh script you can execute. It is used also in the CI

[Nico-Duduf]

@Murmele Formatting done!

I think the question is, if the commit message or the author is more important. If the commit message will be long, the author might not be visible anymore unless we limit the number of characters of the commit message.

I think that's point. IF you show the author in compact mode, it means it's important enough to see it even if there's not a lot of room, so keeping it left makes more sense doesn't it?

Another point. Might it worth creating the checkbox for the author twice to get the old behaviour? So having an author compact (default false) and author normal (default true)?

That would make a lot of checkboxes, and I'm not sure it would be intuitive. The way I'm going to use these options is I set them once and for all, and then just very rarely change them so I don't think it's worth having it twice for the two modes.

Or, but that's a bigger change, the compact/normal mode option could be its own button next to the cog button, and the options under the cog button would be saved according to the mode so that you could set different options for your compact and normal mode, and quickly switch between the two. That may be useful.

[Murmele]

Yes thats the question. Personally I never used the compact mode and probably users will switch only once then they can configure it. If someone will do it, he will write an issue and we can implement it then there. I will merge it as soon as the pipeline runs through.

Thanks for the contribution!

[sudoshindo]

Is this feature released yet? I installed the application from Flathub. Maybe I'm just blind, but I don't see the options anywhere.

[Murmele]

Hi @sudoshindo this is not yet in a stable release.

You can try the flatpak package of the dev version. See the release section here

[sudoshindo]

Release soon?

[Jojo72122]

From where

On Saturday, January 13, 2024, Sudo Shindo @.***> wrote:

Release soon?

— Reply to this email directly, view it on GitHub https://github.com/Murmele/Gittyup/pull/552#issuecomment-1890681749, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6N2VYS53KXLIUEBYCDAWCLYOLH3LAVCNFSM6AAAAAAYCJ6HESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGY4DCNZUHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jojo

[Murmele]

Currently no release is yet planned