search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.55k stars 114 forks source link

Adds "Hide Untracked Files" option to DoubleTreeWidget #591

Closed pablovacatello closed 1 year ago

pablovacatello commented 1 year ago

Adds option to hide untracked files to context menu, which causes the diff to be created with ignored untracked files.

Based on old PR for Gitahead: https://github.com/gitahead/gitahead/pull/232

Animation

Murmele commented 1 year ago

Great job! I will merge it once the ci runs through

Murmele commented 1 year ago

@pablovacatello Can you format the code by executing cl-fmt.sh?

pablovacatello commented 1 year ago

@pablovacatello Can you format the code by executing cl-fmt.sh?

Sure, I'll try to do it later tonight when I'm back at my home PC.

pablovacatello commented 1 year ago

@Murmele done, I pushed a new commit with the code formatted.

It might be a good idea to add a line about code formatting to the "How to Contribute" section in the README.md file for future contributors.

pablovacatello commented 1 year ago

@Murmele it seems cl-fmt.sh changed the format of test/Setting.cpp (which I had never edited) and it was failing the CI. I reverted that file, it should pass now (I hope).

Murmele commented 1 year ago

@Murmele it seems cl-fmt.sh changed the format of test/Setting.cpp (which I had never edited) and it was failing the CI. I reverted that file, it should pass now (I hope).

This might be because of different clang-format versions. We set it up for clang 13 because ubuntu is using it