search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.49k stars 110 forks source link

Repo url that contain logins/password are considered malformed #608

Open Dronec opened 1 year ago

Dronec commented 1 year ago

Gettint the error like: Unable to fetch from 'origin' - malformed URL 'https://login:password@gitserver'

Expected behaviour:

Accept these urls.

Murmele commented 1 year ago

This comes from the libgit2 library, I have to check there. Is an @ allowed? Looks like a misc between http and ssh url

Dronec commented 1 year ago

I believe this is pretty standard in Git

Murmele commented 1 year ago

Can you try the build of this MR? https://github.com/Murmele/Gittyup/pull/153

Dronec commented 1 year ago

Can you try the build of this MR? #153

I'll need to setup the env and it'll take some time. By the way, I checked that the issue isn't in this format ('https://login:password@gitserver/') but in the space in the repo's name, i.e. https://login:password@gitserver/my%20repo

Murmele commented 1 year ago

You can just download the artifact from here: https://github.com/Murmele/Gittyup/actions/runs/5991400133?pr=153

Dronec commented 1 year ago

Looks like the Windows build failed

Murmele commented 1 year ago

I will check next days to get it work. Sorry