search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.37k stars 107 forks source link

Build fail release 1.3.0 #626

Closed Pro-pra closed 10 months ago

Pro-pra commented 10 months ago

Hi all, google not help me there GIT_BUF_INIT_CONST provided :(

/src/git/Branch.cpp:86:17: error: 'GIT_BUF_INIT_CONST' was not declared in this scope; did you mean 'GIT_BUF_INIT'?
   86 |   git_buf buf = GIT_BUF_INIT_CONST(nullptr, 0);
      |                 ^~~~~~~~~~~~~~~~~~
      |                 GIT_BUF_INIT
Murmele commented 10 months ago

Hi, which version of libgit2 are you using? Did you execute git submodule update --init --recursive?

Pro-pra commented 10 months ago

yes, i launch git submodule update --init --recursive

I use system libgit2-1.7.1 and bundled libgit2 with option USE_SYSTEM_LIBGIT2=OFF

this option now deprecated in libgit2 and found in deprecated.h https://github.com/libgit2/libgit2/blob/da265cdf2ed7f7338178b9ed5768af211656e50b/include/git2/deprecated.h#L197

Murmele commented 10 months ago

USE_SYSTEM_LIBGIT2=OFF sounds good, because we are using a patched version of libgit2. Be sure that the bundled libgit version is used.

Pro-pra commented 10 months ago

USE_SYSTEM_LIBGIT2=OFF is help me, thank you!

Murmele commented 10 months ago

Ah ok you had USE_SYSTEM_LIBGIT2=ON previously.