Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.37k stars 107 forks source link

Dropping multiple stashs in a row segfaults #637

Open maurerle opened 9 months ago

maurerle commented 9 months ago

When I drop multiple stashs the Window closes and gittyup segfaults. I have this behavior, when dropping three stashs in a row by clicking the stash entry on branches, select a stash with right click and select drop

In systemd-journalctl i see that it segfaults:

gittyup[685338]: segfault at 21 ip 000055b4415cc843 sp 00007fff8cdec680 error 4 in gittyup[55b441557000+4c6000] likely on CPU 1 (core 1, socket 0)
Sep 23 01:02:07 maurer-fhac kernel: Code: 48 89 de 64 48 8b 04 25 28 00 00 00 48 89 45 c8 31 c0 e8 60 d9 31 00 48 8b 55 90 49 63 ce 48 63 42 08 48 01 c8 48 8b 44 c2 10 <f3> 0f 6f 00 0f 29 45 b0 48 8b 45 b8 48 85 c0 74 0d f0 83 00 01 48
Murmele commented 7 months ago

Do you have a step by step description how you get the segfault?

maurerle commented 7 months ago

I did a screencast where i freshly checked out this project using: (its this repo just for show, the source of this repo is not used)

git clone git@github.com:Murmele/Gittyup.git
*edit a file*
git stash
*edit a file*
git stash
*edit a file*
git stash
*edit a file*
git stash
flatpak run com.github.Murmele.Gittyup

-> branches -> stash -> select stash -> right click -> Drop

Gittyup crashes on the third drop

Screencast from 2023-11-13 21-23-50.webm