Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.37k stars 107 forks source link

Use columns for file name, directory, and state when files are shown as a list in TreeViews. #664

Closed Murmele closed 7 months ago

Murmele commented 7 months ago

Resolves Dense layout issue #547

This MR was created because #632 is force push protected and therefore no rebase can be made

Murmele commented 7 months ago

@gh-devnull can you have a look into it?

gh-devnull commented 7 months ago

@Murmele, this looks good! Thanks for reviewing my changes and fixing up some of the ugliness that crept in. :-)

I left just one comment about how to handle multi-column mode since it affects only the list view but can still be toggled even when list view is off.

Murmele commented 7 months ago

@Murmele, this looks good! Thanks for reviewing my changes and fixing up some of the ugliness that crept in. :-)

I left just one comment about how to handle multi-column mode since it affects only the list view but can still be toggled even when list view is off.

Thanks for your contribution and having to wait so long. Just have to check why the builds are failing because of timeout in fetching qt

Murmele commented 7 months ago

The only thing is this ci build stuff with qt. I have to check. Just wanna that the mac ci build euns also through, not having unexpected problems otherwise

gh-devnull commented 7 months ago

Yeah, the qt ci problems are confounding to me.

I completely agree that it makes sense to resolve them though.