search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.37k stars 107 forks source link

Delete timeline causes crash on windows #680 #693

Closed wolfseifert closed 4 months ago

Murmele commented 4 months ago

Can you fix the formatting?

wolfseifert commented 4 months ago

I made the changes without reformatting, directly at github. I have no idea what is wrong with the formatting. Is the existing code compliant with this formatting check? Maybe you should disable the formatting check for PRs.

Murmele commented 4 months ago

I made the changes without reformatting, directly at github. I have no idea what is wrong with the formatting. Is the existing code compliant with this formatting check? Maybe you should disable the formatting check for PRs.

you have to execute the cl-fmt.sh script. Maybe because the line got longer and then it should be wrapped or something like this.

 ./src/ui/MainWindow.cpp:204:42: error: code should be clang-formatted [-Wclang-format-violations]
  connect(timeline, &QTimeLine::finished, [timeline] { timeline->deleteLater(); });
                                         ^
Failed on file: ./src/ui/MainWindow.cpp

./src/ui/RepoView.cpp:893:42: error: code should be clang-formatted [-Wclang-format-violations]
  connect(timeline, &QTimeLine::finished, [timeline] { timeline->deleteLater(); });
                                         ^
Failed on file: ./src/ui/RepoView.cpp
wolfseifert commented 4 months ago

Done.

Murmele commented 4 months ago

Thanks :) i will merge when ci runs through