search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.37k stars 107 forks source link

Enhance Uncommitted Changes to show git status #704

Open jensenr30 opened 4 months ago

jensenr30 commented 4 months ago

If the git repo is clean, the "Uncommitted Changes" line in the CommitList should say something like "Working tree clean" similar to how git says nothing to commit, working tree clean.

It would also be nice if the Item / text color changed. E.g. green for a clean repo, and bold red for a repo with uncommitted changes. Ideally the colors come from the existing palette / QPalette.

Also if the working tree is clean, then the user should not be able to select that line in the CommitList.

jensenr30 commented 4 months ago

Feel free to assign this issue to me.

Here are some examples of what I'm thinking. Open to critical feedback.

I tried making "working tree clean" green, but it looked weird. Probably best to keep it the same color as the other text.

gittyup-working-tree-clean

I think a dark/faded red background could look good. We could use the same red color as the one from the diff view to keep the theme coherent.

gittyup-uncommitted-changes

Murmele commented 4 months ago

Thanks for the proposal. I think the last image is a little bit too much. Because when looking through the history it forces you always looking on this red banner. I would make something less attracting.

Murmele commented 3 months ago

This is only when the option "Show Clean Status" is enabled right?

Current: grafik

Another issue here is that some changes are shown in the treeview, but selecting one does not show the file (Because there are no changes)