Make CommitList display "Working tree clean"

Murmele / Gittyup

Understand your Git history!

https://murmele.github.io/Gittyup

MIT License

1.37k stars 107 forks source link

Make CommitList display "Working tree clean" #708

Open jensenr30 opened 3 months ago

jensenr30 commented 3 months ago

When there are no changes in the working directory, the top placeholder commit says "Working tree clean".

I added a function bool is_working_tree_clean(void) const in class CommitModel : public QAbstractListModel. Is there a better place to put this function? I'm a C++ beginner. I was trying to figure out how to access the is_working_tree_clean() function in other places in CommitList.cpp but couldn't figure out a clean way to do it...

Resolves #704

Murmele commented 3 months ago

Thanks for the changes. Is this ready? I think the is_working_tree_clean function is fine there

jensenr30 commented 3 months ago

@Murmele I think this is good to merge in, but it might be nice to merge #714 first, because that fixes a bug with this element. But it's your call of course.

jensenr30 commented 2 months ago

@Murmele I will leave this as a Draft until #714 gets merged in because this depends on #714.

Murmele commented 1 month ago

Now this can be rebased as well :)

jensenr30 commented 1 month ago

Hmmm... Looks like I broke some tests... I'll look into this...