search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.37k stars 107 forks source link

Prevent Uncommitted Changes from being shown when ShowCleanStatus is false #714

Closed jensenr30 closed 1 month ago

jensenr30 commented 3 months ago

Previously, it was possible for the Uncommitted Changes row to be appended to the CommitList even if the "Show Clean Status" option had been unchecked. This commit prevents that from happening.

This closes #711.

Murmele commented 3 months ago

@jensenr30 can you rebase?

Murmele commented 2 months ago

Can you fix the tests?

jensenr30 commented 2 months ago

Can you fix the tests?

I will look into why this test is failing and try to fix it.

jensenr30 commented 2 months ago

@Murmele I fixed the test I broke. Now there is a linking error for macos - is that something wrong with my code? Or does that linker error happen on master as well?

Murmele commented 1 month ago

On master this problem does not happen.

ld: Undefined symbols:
  QArrayData::deallocate(QArrayData*, unsigned long, unsigned long), referenced from:
      _main in relauncher.cpp.o
      _main in relauncher.cpp.o
      QStringList::~QStringList() in relauncher.cpp.o
      QList<QString>::detach_helper(int) in relauncher.cpp.o
  QCoreApplication::arguments(), referenced from:
      _main in relauncher.cpp.o
  QCoreApplication::QCoreApplication(int&, char**, int), referenced from:
      _main in relauncher.cpp.o
  QCoreApplication::~QCoreApplication(), referenced from:
      _main in relauncher.cpp.o
      _main in relauncher.cpp.o
  QThread::msleep(unsigned long), referenced from:
      _main in relauncher.cpp.o
  QProcess::startDetached(QString const&), referenced from:
      _main in relauncher.cpp.o
  QListData::erase(void**), referenced from:
      _main in relauncher.cpp.o
  QListData::detach(int), referenced from:
      QList<QString>::detach_helper(int) in relauncher.cpp.o
  QListData::dispose(QListData::Data*), referenced from:
      _main in relauncher.cpp.o
      QStringList::~QStringList() in relauncher.cpp.o
      QList<QString>::detach_helper(int) in relauncher.cpp.o
  QString::toInt(bool*, int) const, referenced from:
      _main in relauncher.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Can you try to rebase?

Murmele commented 1 month ago

Sorry you have to rebase once again, I fixed the macos error in the latest release

jensenr30 commented 1 month ago

I don't mind rebasing. Thanks for fixing the builds :)

Murmele commented 1 month ago

Thank you for the contribution!