search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.37k stars 108 forks source link

Update zip dependency to fix GCC14 build error #759

Closed AHSauge closed 1 month ago

AHSauge commented 1 month ago

The zip submodule is built with -Wextra -Werror. At the very least with GCC14, this results in an error raised by calloc-transposed-args due to a call to calloc where the arguments are swapped around. I've fixed this upstream, and this is pulling the update in. At the time of writing, this means jumping to latest master, involving a jump from 0.2.x to 0.3.x. The minor bump seems to be due to the addition of some new functions.

It should be noted that I'm unable to successfully run ctest since I end up with

The following tests FAILED:
         17 - TreeView (Failed)
         18 - Submodule (Subprocess aborted)
         23 - fileContextMenu (Failed)

This is potentially connected with #546, but in my case I'm just trying to build it locally on my Fedora 40 installation. Additionally, test 17 (but not 18 or 23) fails on my Fedora 38 virtual machine both before and after updating this dependency.

Merge request created anyway since there's clearly a need to either update the zip dependency, or build with different settings for GCC14.

Murmele commented 1 month ago

Can you delete all zip files and adding the zip repository as submodule? https://github.com/richgel999/miniz

AHSauge commented 1 month ago

Can you delete all zip files and adding the zip repository as submodule? https://github.com/richgel999/miniz

Sorry, I'm a bit confused here now. This is updating the existing zip submodule to point to latest (right now) master in https://github.com/kuba--/zip, so from what I can tell there's no files added or removed here, just the submodule reference is updated. GitHub does make it look like there's files change though, but it's just the diff between the previous and new commit used from the submodule.

Maybe there's a misunderstanding here somewhere?

Murmele commented 1 month ago

Can you delete all zip files and adding the zip repository as submodule? https://github.com/richgel999/miniz

Sorry, I'm a bit confused here now. This is updating the existing zip submodule to point to latest (right now) master in https://github.com/kuba--/zip, so from what I can tell there's no files added or removed here, just the submodule reference is updated. GitHub does make it look like there's files change though, but it's just the diff between the previous and new commit used from the submodule.

Maybe there's a misunderstanding here somewhere?

Ah thanks for the hint. It was a missubderstanding on my side :)

alerque commented 1 month ago

Does this fix #766? If so can merging and releasing a minor patch release be made a priority so distro packaging has any chance of being possible?

AHSauge commented 1 month ago

Does this fix #766? If so can merging and releasing a minor patch release be made a priority so distro packaging has any chance of being possible?

It indeed fixes the error in #766.

I'll add that this builds and passes all tests on Arch Linux, at least if done in a chroot environment.