search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.37k stars 108 forks source link

Source directory being used for theme files again, panic at runtime #769

Open alerque opened 1 month ago

alerque commented 1 month ago

Some form of the issue we saw in #167 is back for 1.4.0. Packages I built on an offline build system (Arch Linux official package builder) are throwing an error at run time:

PANIC: unprotected error in call to Lua API (cannot open /build/gittyup/src/Gittyup/conf/System.lua: No such file or directory)

This is looking for a Lua file at the path it would have been during the build process instead of looking for it where it should be installed. The file is installed at /usr/share/gittyup/Gittyup/themes/System.lua in the final package, but that location is not found and the panic happens because it only looks in where the source directory was at build time. In this case that is in a chroot on a different system and hence is not available at run time.

ftaiolivista commented 1 month ago

Same for me

PANIC: unprotected error in call to Lua API (cannot open /home/user/.cache/paru/clone/gittyup/src/Gittyup/conf/System.lua: No such file or directory)
[1]    108341 IOT instruction (core dumped)  gittyup

Cannot installa anymore

Murmele commented 1 month ago

Can you show the debug output in the console? Not sure yet if there is a cmake option to enable them without the gui.

Murmele commented 1 month ago

@alerque do you have the same problem?

ftaiolivista commented 1 month ago

Now it seems to work. No more errors installing aur package (gittyup 1.4.0-1). I'm using paru.

Murmele commented 1 month ago

Thanks for testing

ftaiolivista commented 2 weeks ago

Sorry. I cleaned up paru cache and reinstalled gittyup and now it fail to start.

PANIC: unprotected error in call to Lua API (cannot open /home/vista/.cache/paru/clone/gittyup/src/Gittyup/conf/System.lua: No such file or directory)
[1]    85660 IOT instruction (core dumped)  gittyup .

Before was working because the file was present in the paru cache someway

stingray21 commented 1 week ago

Having the same issue (on Manjaro Linux)

I can install it but then I cannot launch it, see error below

PANIC: unprotected error in call to Lua API (cannot open /tmp/pamac-build-user/gittyup/src/Gittyup/conf/System.lua: No such file or directory)
[1]    53284 IOT instruction (core dumped)  gittyup

The src folder in tmp gets deleted in the "Cleaning up" step of the install. When I then manually add it back (clone it from git), I can launch the app again.

But it seems like the tmp folder should not be the place where these files should live.