MurmurationsNetwork / MurmurationsProtocol

Murmurations is a distributed data sharing protocol
https://murmurations.network
GNU General Public License v3.0
10 stars 1 forks source link

Use profile URL as unique ID for node #12

Closed geoffturk closed 4 years ago

geoffturk commented 4 years ago
geoffturk commented 4 years ago

Advantages

Disadvantages

olisb commented 4 years ago

Possible disadvantage (although I guess this applies in other circumstances too and is hence not just related to using the profile URL as the unique ID) is abuse: A bad actor could create a fake profile and host this somewhere... whereas, if the profileurl had to contain the entity's URL, or a recognised (authorised?) hosts URL, we would be able to identify fake profiles.

geoffturk commented 4 years ago

@olisb See my comment about checking that the root domain is the same between the profileUrl and the url (primary URL of the organization) to determine if there is potential spoofing.

Overall the advantages are pretty significant so we will go forward with using the hash of the profileUrl (the nodeId) as the unique identifier of a node in the index.