Closed nossleinad closed 6 months ago
Attention: Patch coverage is 98.36066%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 32.99%. Comparing base (
6930e8d
) to head (3abdcf3
).
Files | Patch % | Lines |
---|---|---|
src/core/algorithms/branchlength_optim.jl | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request implements Brent's method for minimization and calls it
brents_method_minimize
. It also makes it an option as an optimizer forbranchlength_optim!
. This method can be used for 1D unimodal optimization problems and it doesn't use derivatives.Additionally, this pull request generalizes
golden_section_maximize
andbrents_method_minimize
withunivariate_maximize
. It dispatches on the two different subtypes,GoldenSectionOpt
andBrentsMethodOpt
, of the newUnivariateOpt
-type.