Crashes all the time

[kpuljek]

Wally crashes when opening images. Not all of them, but a significant percentage.

[wispborne]

If you are still interested, you are welcome to try out my fork, which should fix the crash issues.

https://github.com/davidwhitman/wally/releases/tag/1.6.0-davidwhitman

Note that you will need to uninstall the official Wally before installing my .apk (they cannot coexist).

[a-random-package]

Just tried your forks APK and it's crashing on Android N.

[wispborne]

Thanks @a-random-package for trying. Unfortunately I don't have access to the same logging that the original author does (I didn't add my own logging) so I can only guess at the causes.

I will say that the apk runs fine for me, also on Android N (both 7 and 7.1). It DOES crash if you deny the "Access to files" permission, so make sure you've enabled that. If it doesn't prompt you, you'll need to go into Settings - Apps and enable it.

If it's not permissions, then I really don't know :(

[a-random-package]

Thanks. I have allowed the permission but still same issue. I'll build from source and try again

[a-random-package]

Project won't build. Gives me this error right off the bat:

Error:Execution failed for task ':wally:mergeDebugResources'.

Error: com.android.builder.internal.aapt.AaptException: Failed to crunch file C:\Users\alexm\Google Drive\private\CLIENT WORK\When I was HIgh\MOBILE_WALLPAPERS\Android App\wally-1.6.0-davidwhitman\wally\build\intermediates\exploded-aar\com.android.support\appcompat-v7\25.0.1\res\drawable-hdpi-v4\abc_ic_menu_share_mtrl_alpha.png into C:\Users\alexm\Google Drive\private\CLIENT WORK\When I was HIgh\MOBILE_WALLPAPERS\Android App\wally-1.6.0-davidwhitman\wally\build\intermediates\res\merged\debug\drawable-hdpi-v4\abc_ic_menu_share_mtrl_alpha.png

[a-random-package]

Fixed the issue by moving the source folder. Built in AS and runs just fine now. Thanks for your work!

[wispborne]

While I'm really glad (and impressed) that you got it working, it seems mysterious that it wasn't before. I did make some modifications that weren't in the original apk I had you install, but they were just to handle the case where the permission wasn't granted so they shouldn't have changed anything...

Or maybe it's because you had it in your Google Drive folder and that was messing it up?

It sounds like the changes I didn't think would fix it, actually fixed it, and you got them when you built directly from the source.

[a-random-package]

Sorry for hijacking this issue thread, but I am not a developer first so I have a big question. I have dug through the source and emailed Musenkishi with no response. How in the heck do I add my own wallpaper repo to the code? I distribute wallpapers through a website I manage and we wanted to use Wally to distribute them via Google Play. Can we do this with this source?

[wispborne]

Alright, I spent literally five minutes looking through the code, so don't treat this as gospel, but...

You'll see the link to wallhaven here: https://github.com/Musenkishi/wally/blob/master/dataprovider/src/main/java/com/musenkishi/wally/dataprovider/NetworkDataProvider.java

However, as you'll see from looking through that code, it's highly tailored to wallhaven specifically. So you'll need to modify that to build your sites' url properly. For example, wallhaven has the concept of 'purity', ie nudity. If your site doesn't have that, you'll need to tweak some stuff to remove it.

Also, wallhaven has no actual api from what I can see. Wally simply extracts the images from the http response and ignores the rest of the content. I didn't look at this process too closely.

The good news is that the dev did a really good job, it seems, of separating the data source (that is, wallhaven) from the rest of the code. So as long as you can get the dataprovider module working with your site, it should work more or less.

[phanirithvij]

@davidwhitman Wallhaven has an API now https://wallhaven.cc/help/api#wallpapers

[wispborne]

@phanirithvij oh, that's super useful. Because Wally isn't my app, and because it works fine as-is, I don't have any plans to change to use the API, though.