search

MuseumStat / imls-museum-data

IMLS Museum Data
Apache License 2.0
4 stars 7 forks source link

Fix broken sentence in about.html #151

Closed CloudNiner closed 7 years ago

CloudNiner commented 7 years ago

@nevillevak can you review quick and make sure this matches what you expect?

Closes #150

nevillevak commented 7 years ago

@CloudNiner - The updated text does not appear to be on the live page. It still shows the incomplete sentence. Is there somewhere else I should be looking? Please advise.

CloudNiner commented 7 years ago

Ah, sorry if that was unclear. The change is in the "files changed" tab of this pull request, make sure the text in the green line there matches what you would expect. I haven't pushed the update yet.

nevillevak commented 7 years ago

Hi. Thanks for clarifying. Now that I see the full text, the sentence should read: "The museum data are combined with community metrics on every census tract in the United States." (We don't need "U.S." between the words "every" and "census")

CloudNiner commented 7 years ago

Thanks for taking a look. Updated again, going to merge this and then deploy sometime before tomorrow am.

nevillevak commented 7 years ago

Great. Also note that we still need to add "United States" at the end of that sentence. Sorry to make something so simple so complicated!

CloudNiner commented 7 years ago

Right. So this screenshot is correct, yes?

screen shot 2017-01-23 at 14 44 21
nevillevak commented 7 years ago

Yes. Thanks!

Best, Neville

Neville K. Vakharia Assistant Professor and Research Director Drexel University, Westphal College of Media Arts & Design Department of Arts & Entertainment Enterprise 215.571.4439, nvakharia@drexel.edu

Office Hours: Tuesdays and Thursdays, 2:00 – 5:00 By appointment only

From: Andrew Fink notifications@github.com Reply-To: MuseumStat/imls-museum-data reply@reply.github.com Date: Monday, January 23, 2017 at 2:45 PM To: MuseumStat/imls-museum-data imls-museum-data@noreply.github.com Cc: nevillevak nvakharia@drexel.edu, Assign assign@noreply.github.com Subject: Re: [MuseumStat/imls-museum-data] Fix broken sentence in about.html (#151)

Right. So this screenshot is correct, yes?

[creen shot 2017-01-23 at 14 44 21]https://cloud.githubusercontent.com/assets/1818302/22219881/88a9dbf8-e17a-11e6-9b80-b70adc900394.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/MuseumStat/imls-museum-data/pull/151#issuecomment-274595858, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANMluTLoGTEoxqiyVJZxU5iljae_83OFks5rVQNSgaJpZM4LoM0N.