MushroomObserver / mushroom-observer

A website for sharing observations of mushrooms.
https://mushroomobserver.org
MIT License
77 stars 25 forks source link

Locationless Project Violations #2072

Closed JoeCohen closed 5 months ago

JoeCohen commented 5 months ago

Constraint Violations:

  1. throws an Error for Projects with nil Locations see below
  2. mistakenly flags lat/lon as violations if the above error is fixed
    
    NFO -- : Started GET "/projects/341/violations" for 204.195.36.191 at 2024-03-29 01:47:17 +0000
    INFO -- : Processing by Projects::ViolationsController#index as HTML
    INFO -- :   Parameters: {"project_id"=>"341"}
    WARN -- : user=4468 robot=N ip=204.195.36.191
    INFO -- :   Rendered layout controllers/layouts/application.html.erb (Duration: 196.1ms | Allocations: 4085)
    INFO -- : Completed 500 Internal Server Error in 335ms (ActiveRecord: 286.8ms | Allocations: 8278)
    E, [2024-03-29T01:47:18.001494 #341300] ERROR -- :   
    ActionView::Template::Error (undefined method `contains_lat?' for nil):
    15:     <%=
    16:       make_table(
    17:         headers: violation_table_headers(@project),
    18:         rows: violation_table_rows(
    19:           form: form, project: @project, violations: @violations
    20:         )
    21:       )

app/helpers/projects_helper.rb:89:in styled_obs_lat' app/helpers/projects_helper.rb:23:inblock in violation_table_rows' app/helpers/projects_helper.rb:18:in each' app/helpers/projects_helper.rb:18:ineach_with_object' app/helpers/projects_helper.rb:18:in violation_table_rows' app/views/controllers/projects/violations/index.html.erb:18 app/views/controllers/projects/violations/index.html.erb:10 app/controllers/application_controller.rb:226:incatch_errors_and_log_request_stats'