MushroomObserver / mushroom-observer

A website for sharing observations of mushrooms.
https://mushroomobserver.org
MIT License
77 stars 25 forks source link

Make map behavior more predictable #2092

Closed nimmolo closed 3 months ago

nimmolo commented 3 months ago

Screen Shot 2024-04-11 at 4 36 31 PM

nimmolo commented 3 months ago

@mo-nathan @JoeCohen If you have time, please check in on the discussion in #2088. Whatever the consensus is, i'll apply it to this PR.

coveralls commented 3 months ago

Coverage Status

coverage: 94.409% (+0.002%) from 94.407% when pulling 0f908c51d80342247b9edff643ac3aababf675b4 on nimmo-exclude-vague-locations-from-maps into 3ce08662b9708da021950f6578fd551051457db3 on main.

JoeCohen commented 3 months ago

@nimmolo:

  1. I agree that this is a huge improvement over main and well worth doing as a "stopgap".
  2. I'm not sure which part of discussion #2088 you're referring to. If it's the part about overlapping points, I slightly prefer representing them as a box.
  3. Are there boxes which, when clicked, will display a map of point locations within the box? If so, maybe differentiate those from boxes which don't display another map when clicked.
  4. Please ignore the following unless it's easy to deal with in this PR. The PR is a big enough win to be merged without dealing with the following. There's an issue with boxes which contain both geolocated and un-geolocated Observations. I'd like to see a map with pins for the geolocated Observations, but I only see a map with boxes. Example:

Each smaller box represents a single, un-geolocated Observation with a Location whose box is smaller than Klickitat Co. The larger box outlines Klickitat Co.

If you click Show All, it lists 5 Observations: the 2 without lat/lon, and 3 with lat/lon. Somehow, 2 of the geolocated Observations have gone missing.

I have no clue why two of the results have disappeared. Bug in query? Wrong query string? Something else? I can't figure out how to get a map of only points.

JoeCohen commented 3 months ago

Maybe use a different symbol instead of a box if the the box represents only a combination of (a) any ungeolocated Observations and (b) any Observations with hidden geolcation. Possibilities include: a circle, a different color/shape pin.

nimmolo commented 3 months ago

@JoeCohen - good catch re: points in Klickitat County.

I just pushed a change where it lets points through if the number of objects is below the max, i.e. if there's no chance the points will be auto-aggregated and potentially become invisible, like Joanne's in Santa Cruz Island on the larger occurrence map.

This is a definite improvement that I would have missed, thank you. Your example in Klickitat now shows points.

This will only work if Google somehow provides separate captions for coinciding points, because there will be plenty of these. If that's not possible, we're stuck with boxes for the long term, and I can invest more time into differentiating them.

nimmolo commented 3 months ago

@JoeCohen The question in #2088 is my two long illustrated posts at the bottom, regarding maps for single observations. This PR changes the default to favor the geolocation over the associated MO location in all cases.