search

MushroomObserver / mushroom-observer

A website for sharing observations of mushrooms.
https://mushroomobserver.org
MIT License
77 stars 26 forks source link

Hidden locations #2121

Closed mo-nathan closed 2 months ago

mo-nathan commented 2 months ago

To test: 1) Create a new Location and set it hidden (checkbox at the top of the edit form) 2) Note that lat/long values cannot be more precise than 0.1 degrees. 3) Associate an observation with lat/long with this location. 4) Note that the observation is forced to have it's GPS hidden.

See #1945 for more notes/discussion.

coveralls commented 2 months ago

Coverage Status

coverage: 94.446% (+0.003%) from 94.443% when pulling 98fe9f198fb6c7dcc0c6ee2605b5bd486a7d5a74 on njw-hidden-locations into 2fcde2aa28d7f6c85b121be16498214b5a0811fe on main.

mo-nathan commented 2 months ago

Here's one interesting hypothetical: A hidden Location with Observations is merged into a non-hidden Location. (Note that only Admins can do this.)

  • The Observations' GPS will become public.
  • Should this merger even be allowed?

Yeah, I thought about it a bit and ended up feeling we shouldn't limit what admins can do. Putting in a warning might be worthwhile, but it feels pretty edge casey to me.