search

MushroomObserver / mushroom-observer

A website for sharing observations of mushrooms.
https://mushroomobserver.org
MIT License
77 stars 26 forks source link

Adjust script/extract_log to handle non-utf8 sequences. #2124

Closed pellaea closed 2 months ago

pellaea commented 2 months ago

The "real" problem is why are there non-utf8 sequences in the log??? But be that as it may, code should never crash, as a general rule, and I can at least fix that...

coveralls commented 2 months ago

Coverage Status

coverage: 94.446%. remained the same when pulling 7708bd311a328143884f5380a6d0effa3d070879 on protect-extract-log-from-non-utf8 into 666f0c4b18d455565732bb41fb9426a68e68aa2e on main.

mo-nathan commented 2 months ago

Thanks for fixing this. Given all the monkeys banging on all the keyboards, I can see non-utf8 sequences ending up in the log. I can specifically imagine monkeys with bad intent throwing binary data where it shouldn't go.

pellaea commented 2 months ago

:) Yep, I'm not overly concerned.

On Wed, May 1, 2024 at 8:35 AM Nathan Wilson @.***> wrote:

Thanks for fixing this. Given all the monkeys banging on all the keyboards, I can see non-utf8 sequences ending up in the log. I can specifically imagine monkeys with bad intent throwing binary data where it shouldn't go.

— Reply to this email directly, view it on GitHub https://github.com/MushroomObserver/mushroom-observer/pull/2124#issuecomment-2088404123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYTNNLUS4BIX3WGBBLFJDTZADORPAVCNFSM6AAAAABHBGIGX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGQYDIMJSGM . You are receiving this because you modified the open/close state.Message ID: @.***>