MushroomObserver / mushroom-observer

A website for sharing observations of mushrooms.
https://mushroomobserver.org
MIT License
77 stars 26 forks source link

Field Slip Forms #2160

Closed mo-nathan closed 1 week ago

mo-nathan commented 1 month ago

On this branch you can now add all the information requested by a field slip (except whether it has a photo or not) on the edit field slip page. The data will be stored and/or synched with the data in any associated observation. If no observation is currently associated with the field slip, then the field slip data will be added to the new observation. If a new observation is not created and you navigate away from the create observation page, then the new field slip data will be lost. Most of the field slip data gets stored as fields in the Notes section of the observation.

Currently there is separate date info associated with the field slip and the observation. Not sure that's right, but I don't know that it's a big deal and I can at least imagine situations where they could be different.

If a field slip id is added then the existing namings are checked and if that name has not been applied to any existing observation, then it gets applied with a default vote of "I'd Call It That". My goal with all of this is to make the "happy path" for recorders at events as straight forward as possible. There's still a bit of a rough edge in how someone at a computer should be scanning the QR codes. It's possible to use one of the online QR code readers, but it would be better if there was an option in the website, but I think that's work for another ticket.

In the process I also cleaned up the CRUD for field slips to bring them more in line with what we do elsewhere in the site.

Here are some specific scenarios I used while developing:

1) As a project admin, I would create a new field slip with a URL something like http://localhost:3000/qr/NFAL-00010. You’ll need to add yourself as an admin or login as me if you use the NFAL project. Fill out the form (play with the auto-completes including providing values that aren’t in MO) and click ‘Create New Observation’. Ensure that all the data gets saved and that you can edit the fields etc. Auto-complete values that match stuff in the database should get rendered as reasonable Textile.

2) As a non-admin create a new field slip with a similar URL and create a new observation, but don’t add much data (include no name or non-specific names). Then as an admin go to the same URL (should take you to the observation). Now click on the field slip on the right hand side. Fill in the data as though it were coming from a field slip, but now with a name from some mycologist. Ensure that the new data and name get applied correctly to the observation. Note that the naming will still come from you, but the Field Slip ID By field should show the mycologist’s name.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.482% (+0.03%) from 94.454% when pulling 4aee596a68591a90e93c05b76767333b5b2e2e9d on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.482% (+0.03%) from 94.454% when pulling 4aee596a68591a90e93c05b76767333b5b2e2e9d on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.482% (+0.03%) from 94.454% when pulling 4aee596a68591a90e93c05b76767333b5b2e2e9d on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling 4b0317d29a568cc5de7ba65096a6b70db1d2357f on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling 4b0317d29a568cc5de7ba65096a6b70db1d2357f on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling 4b0317d29a568cc5de7ba65096a6b70db1d2357f on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling def55326c97856d96801ecd7dfa96d9dfbdc7582 on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling def55326c97856d96801ecd7dfa96d9dfbdc7582 on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling def55326c97856d96801ecd7dfa96d9dfbdc7582 on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling def55326c97856d96801ecd7dfa96d9dfbdc7582 on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling def55326c97856d96801ecd7dfa96d9dfbdc7582 on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 3 weeks ago

Coverage Status

coverage: 94.489% (+0.04%) from 94.454% when pulling def55326c97856d96801ecd7dfa96d9dfbdc7582 on njw-field-slip-forms into b42b7a7457856d910019f10b17d22298abed812d on main.

coveralls commented 2 weeks ago

Coverage Status

coverage: 94.429% (+0.04%) from 94.393% when pulling 7f0a4e0dd33aa4e45614a253c12493b0d98b80a0 on njw-field-slip-forms into f0330dea85d0d4f1da74759cc7fcc0337981c6cb on main.

coveralls commented 2 weeks ago

Coverage Status

coverage: 94.429% (+0.04%) from 94.393% when pulling 7f0a4e0dd33aa4e45614a253c12493b0d98b80a0 on njw-field-slip-forms into f0330dea85d0d4f1da74759cc7fcc0337981c6cb on main.

coveralls commented 2 weeks ago

Coverage Status

coverage: 94.429% (+0.04%) from 94.393% when pulling 7f0a4e0dd33aa4e45614a253c12493b0d98b80a0 on njw-field-slip-forms into f0330dea85d0d4f1da74759cc7fcc0337981c6cb on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.433% (+0.04%) from 94.398% when pulling 8222a519e61e8fba44c6f1f27444c632a58f15ed on njw-field-slip-forms into 875361dc729b6bd3f062117232546bcc77584d1b on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.433% (+0.04%) from 94.398% when pulling 8222a519e61e8fba44c6f1f27444c632a58f15ed on njw-field-slip-forms into 875361dc729b6bd3f062117232546bcc77584d1b on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.433% (+0.04%) from 94.398% when pulling 8222a519e61e8fba44c6f1f27444c632a58f15ed on njw-field-slip-forms into 875361dc729b6bd3f062117232546bcc77584d1b on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.433% (+0.04%) from 94.398% when pulling 8222a519e61e8fba44c6f1f27444c632a58f15ed on njw-field-slip-forms into 875361dc729b6bd3f062117232546bcc77584d1b on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.433% (+0.04%) from 94.398% when pulling 8222a519e61e8fba44c6f1f27444c632a58f15ed on njw-field-slip-forms into 875361dc729b6bd3f062117232546bcc77584d1b on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.433% (+0.04%) from 94.398% when pulling 8222a519e61e8fba44c6f1f27444c632a58f15ed on njw-field-slip-forms into 875361dc729b6bd3f062117232546bcc77584d1b on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.428% (+0.03%) from 94.399% when pulling f6fb68ce72b92452a59841703191811fe63457d3 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.428% (+0.03%) from 94.399% when pulling f6fb68ce72b92452a59841703191811fe63457d3 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.428% (+0.03%) from 94.399% when pulling f6fb68ce72b92452a59841703191811fe63457d3 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.428% (+0.03%) from 94.399% when pulling f6fb68ce72b92452a59841703191811fe63457d3 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.428% (+0.03%) from 94.399% when pulling f6fb68ce72b92452a59841703191811fe63457d3 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.428% (+0.03%) from 94.399% when pulling f6fb68ce72b92452a59841703191811fe63457d3 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.429% (+0.03%) from 94.399% when pulling 1608ac1f8211265f3255954f386c359997f21e80 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.429% (+0.03%) from 94.399% when pulling 1608ac1f8211265f3255954f386c359997f21e80 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.429% (+0.03%) from 94.399% when pulling 1608ac1f8211265f3255954f386c359997f21e80 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.43% (+0.03%) from 94.399% when pulling b7a4c54cb805f54b91d58fb0e7dcc738975f0328 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.43% (+0.03%) from 94.399% when pulling b7a4c54cb805f54b91d58fb0e7dcc738975f0328 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.43% (+0.03%) from 94.399% when pulling b7a4c54cb805f54b91d58fb0e7dcc738975f0328 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.43% (+0.03%) from 94.399% when pulling b7a4c54cb805f54b91d58fb0e7dcc738975f0328 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.43% (+0.03%) from 94.399% when pulling b7a4c54cb805f54b91d58fb0e7dcc738975f0328 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.43% (+0.03%) from 94.399% when pulling b7a4c54cb805f54b91d58fb0e7dcc738975f0328 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.452% (+0.05%) from 94.399% when pulling 5326b468dbae6d63ea5e3cfd0a5720b560ab95d4 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.452% (+0.05%) from 94.399% when pulling 5326b468dbae6d63ea5e3cfd0a5720b560ab95d4 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.452% (+0.05%) from 94.399% when pulling 5326b468dbae6d63ea5e3cfd0a5720b560ab95d4 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.452% (+0.05%) from 94.399% when pulling 2ca3a5f227866deecb32be042782ef8912673d0c on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.452% (+0.05%) from 94.399% when pulling 2ca3a5f227866deecb32be042782ef8912673d0c on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.452% (+0.05%) from 94.399% when pulling 2ca3a5f227866deecb32be042782ef8912673d0c on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.454% (+0.06%) from 94.399% when pulling 0dfd00e0350a54015cfc0e2a06f87c5183afb594 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.454% (+0.06%) from 94.399% when pulling 0dfd00e0350a54015cfc0e2a06f87c5183afb594 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.454% (+0.06%) from 94.399% when pulling 0dfd00e0350a54015cfc0e2a06f87c5183afb594 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.454% (+0.06%) from 94.399% when pulling 7392e20f3577a02a9944f9bcb7d92172f1d286e5 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

coveralls commented 1 week ago

Coverage Status

coverage: 94.454% (+0.06%) from 94.399% when pulling 7392e20f3577a02a9944f9bcb7d92172f1d286e5 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.

mo-nathan commented 1 week ago

@JoeCohen and @nimmolo, I believe this is ready for another review. I'm not aware of any outstanding issues. I think the project constraints are behaving consistently and I fixed a few bugs I found along the way. The latest work is summarized at the end of issue #1950.

coveralls commented 1 week ago

Coverage Status

coverage: 94.454% (+0.06%) from 94.399% when pulling 7392e20f3577a02a9944f9bcb7d92172f1d286e5 on njw-field-slip-forms into 61c1a81ffc06eda9d67373fabca23982de4366f6 on main.