search

MushroomObserver / mushroom-observer

A website for sharing observations of mushrooms.
https://mushroomobserver.org
MIT License
77 stars 25 forks source link

Refactor some name resolver var, ivar assignments #2196

Closed nimmolo closed 3 months ago

nimmolo commented 3 months ago

No big changes, same result. Minor change: renames @what as @given_name. At first i was getting an error "what is not allowed as an instance variable name" but it turned out to be due to the way i was calling instance_variable_set, not the var name. In any case,@given_name seems less ambiguous, though less cute, so i'm inclined to keep it. Often I've wondered, "what is @what?"

coveralls commented 3 months ago

Coverage Status

coverage: 94.395% (+0.002%) from 94.393% when pulling 7cf6a5908f438ca40d18878fef941216e7165cf1 on name-resolver-ivars into c9c7760647167a9bd727825ad25c860ef1b8c6a6 on main.

coveralls commented 3 months ago

Coverage Status

coverage: 94.395% (+0.002%) from 94.393% when pulling 7cf6a5908f438ca40d18878fef941216e7165cf1 on name-resolver-ivars into c9c7760647167a9bd727825ad25c860ef1b8c6a6 on main.

coveralls commented 3 months ago

Coverage Status

coverage: 94.396% (+0.003%) from 94.393% when pulling 5cc24200510f6ac4813d47e4027e4dae231746f1 on name-resolver-ivars into c9c7760647167a9bd727825ad25c860ef1b8c6a6 on main.