Update room_env.py - Githubissues

MushroomRL / mushroom-rl

Python library for Reinforcement Learning.

MIT License

803 stars 145 forks source link

Update room_env.py #143

Closed Katze2664 closed 3 months ago

Katze2664 commented 3 months ago

ValueError needs to be raised not asserted

boris-il-forte commented 3 months ago

Thanks for the pull request. However, you should rebase your commits to dev, not to master. We don't accept pull requests on master.

Katze2664 commented 3 months ago

Sorry about that. Thanks for changing the base branch to dev for me. I will rebase to dev in future. Is there anything else I need to do to finish off this PR?

boris-il-forte commented 3 months ago

You need to resolve the conflicts (just rebase your branch properly). The same holds for the other pull request.