Music-Visualization-MQP / mono-repo

0 stars 0 forks source link

house-keeping: discuss merge protocol #53

Open ibixler opened 4 days ago

notsoli commented 3 days ago

A PR can only be merged once ALL changes are approved. PR's can fall into two informal, subjective categories: small or large

Once all changes are approved, the PR opener can merge without verbal confirmation.

If a problem is identified, it is up to either the approver or PR author to fix the problems. Once the problem is fixed, the PR requires one extra approval (regardless or not if the PR is small or large). If these changes are approved, the PR can be merged. If not, this process repeats.