Closed schneiderfelipe closed 2 years ago
omnizart supports Python 3.8
https://github.com/Music-and-Culture-Technology-Lab/omnizart/blob/86bd36353e3eb410b5db3c18ef05f31dabfb0c7f/pyproject.toml#L26
but it's not tested during CI
https://github.com/Music-and-Culture-Technology-Lab/omnizart/blob/86bd36353e3eb410b5db3c18ef05f31dabfb0c7f/.github/workflows/general.yml#L20
Maybe the above should be changed to python-version: [3.6, 3.8], so that the oldest and newest supported versions get tested? (I believe this can be seen as a step towards partly solving #65, or at least avoiding similar issues in the future.)
python-version: [3.6, 3.8]
Approved.
BreezeWhite
commented
2 years ago
omnizart supports Python 3.8
https://github.com/Music-and-Culture-Technology-Lab/omnizart/blob/86bd36353e3eb410b5db3c18ef05f31dabfb0c7f/pyproject.toml#L26
but it's not tested during CI
https://github.com/Music-and-Culture-Technology-Lab/omnizart/blob/86bd36353e3eb410b5db3c18ef05f31dabfb0c7f/.github/workflows/general.yml#L20
Maybe the above should be changed to
python-version: [3.6, 3.8], so that the oldest and newest supported versions get tested? (I believe this can be seen as a step towards partly solving #65, or at least avoiding similar issues in the future.)