MusicPlayerDaemon / MPD

Music Player Daemon
https://www.musicpd.org/
GNU General Public License v2.0
2.16k stars 346 forks source link

Extend robustness of cdda playback #1997

Closed lazypingu closed 6 months ago

lazypingu commented 7 months ago

This PR tries to address some CDDA playback issues.

Changes:

  1. Moved speed adjutment after cdio_cddap_open as done in cd-paranoia (this seems to prevent errors on speed adjustment)
  2. Use sector functions from libcdio-paranoia (cdio_cddap_*) to detect sectors (this seems to increase the robustness on special cases like hidden tracks or multisession CDs)
  3. Added checks for errors on lsns and non audio tracks

Improvments:

MaxKellermann commented 7 months ago

Now there are two more fixup commits for known-bad PR commits.

lazypingu commented 7 months ago

@MaxKellermann Got your point. Thanks! I've tried to rewrite the history with all suggestions.

MaxKellermann commented 6 months ago

I find your commit messages very lacking still.

lazypingu commented 6 months ago

@MaxKellermann I've tried to specify the commit messages for more clarity.