search

MusicPlayerDaemon / MPD

Music Player Daemon
https://www.musicpd.org/
GNU General Public License v2.0
2.11k stars 338 forks source link

android: Install the libmpd.so output on android #2031

Closed DDRBoxman closed 1 month ago

DDRBoxman commented 2 months ago

libmpd.so was getting written as a file called arm64-v8a instead of arm64-v8a/libmpd.so

MaxKellermann commented 2 months ago

This time you're adding a Python script instead of a shell script, which is better... but this still looks more complicated than it should be. Isn't there another, simpler way to do this? Also your old commit 906d58a918d looks pretty wrong. It does not properly declare the target file; it pretends to output to OUTPUT/android/apk/libmpd.so (via output: parameter) but it really copies to meson.current_source_dir()/.... - due to this mistake, Ninja is unable to find the output file and thus copies the file again even if it already exists.

DDRBoxman commented 2 months ago

Looks like output is just for names and can't take a path. Setting up the install path and calling install might be an option?

DDRBoxman commented 2 months ago

Okay, switched this over to use install