MusicPlayerDaemon / MPD

Music Player Daemon
https://www.musicpd.org/
GNU General Public License v2.0
2.18k stars 352 forks source link

udisks2 neighbor plugin ignores suffix when using mount command #487

Closed muesli4 closed 5 years ago

muesli4 commented 5 years ago

Compiled from commit 281461f0f07b27253f39a96d1c576d5f410b5802.

Music Player Daemon 0.21.4 (0.21.4)

Copyright 2003-2007 Warren Dukes <warren.dukes@gmail.com>
Copyright 2008-2018 Max Kellermann <max.kellermann@gmail.com>
This is free software; see the source for copying conditions.  There is NO
warranty; not even MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Database plugins:
 simple proxy upnp

Storage plugins:
 local smbclient udisks nfs curl

Neighbor plugins:
 smbclient upnp udisks

Decoders plugins:
 [mad] mp3 mp2
 [mpg123] mp3
 [vorbis] ogg oga
 [oggflac] ogg oga
 [flac] flac
 [opus] opus ogg oga
 [sndfile] wav aiff aif au snd paf iff svx sf voc w64 pvf xi htk caf sd2
 [audiofile] wav au aiff aif
 [dsdiff] dff
 [dsf] dsf
 [hybrid_dsd] m4a
 [faad] aac
 [mpcdec] mpc
 [wavpack] wv
 [modplug] 669 amf ams dbm dfm dsm far it med mdl mod mtm mt2 okt s3m stm ult umx xm
 [mikmod] amf dsm far gdm imf it med mod mtm s3m stm stx ult uni xm
 [wildmidi] mid
 [fluidsynth] mid
 [ffmpeg] 16sv 3g2 3gp 4xm 8svx aa3 aac ac3 adx afc aif aifc aiff al alaw amr anim apc ape asf atrac au aud avi avm2 avs bap bfi c93 cak cin cmv cpk daud dct divx dts dv dvd dxa eac3 film flac flc fli fll flx flv g726 gsm gxf iss m1v m2v m2t m2ts m4a m4b m4v mad mj2 mjpeg mjpg mka mkv mlp mm mmf mov mp+ mp1 mp2 mp3 mp4 mpc mpeg mpg mpga mpp mpu mve mvi mxf nc nsv nut nuv oga ogm ogv ogx oma ogg omg opus psp pva qcp qt r3d ra ram rl2 rm rmvb roq rpl rvc shn smk snd sol son spx str swf tak tgi tgq tgv thp ts tsp tta xa xvid uv uv2 vb vid vob voc vp6 vmd wav webm wma wmv wsaud wsvga wv wve
 [gme] ay gbs gym hes kss nsf nsfe sap spc vgm vgz
 [pcm]

Filters:
 libsamplerate soxr

Tag plugins:
 id3tag

Output plugins:
 shout null fifo pipe alsa ao oss openal solaris pulse jack httpd recorder

Encoder plugins:
 null vorbis opus lame twolame wave flac

Archive plugins:
 [bz2] bz2
 [zzip] zip
 [iso] iso

Input plugins:
 file archive alsa tidal qobuz curl ffmpeg smbclient nfs mms cdio_paranoia

Playlist plugins:
 extm3u m3u pls xspf asx rss soundcloud flac cue embcue

Protocols:
 file:// alsa:// tidal:// qobuz:// http:// https:// gopher:// rtp:// rtsp:// rtmp:// rtmpt:// rtmps:// smb:// nfs:// mms:// mmsh:// mmst:// mmsu:// cdda://

Other features:
 avahi dbus udisks epoll icu inotify ipv6 systemd tcp un

I would expect that MPD uses the given path as root in the corresponding filesystem.

[moritz@phi ~]$ telnet localhost 6600
Trying ::1...
Connected to localhost.
Escape character is '^]'.
OK MPD 0.21.4
listneighbors
neighbor: udisks://by-uuid-BD91-9BCD
name: /org/freedesktop/UDisks2/block_devices/sdc4
neighbor: udisks://by-uuid-9569-6A93
name: /org/freedesktop/UDisks2/block_devices/sdc3
neighbor: udisks://by-uuid-4FBEA9E54FD3B290
name: /org/freedesktop/UDisks2/block_devices/sdc2
neighbor: udisks://by-uuid-4E72-568E
name: /org/freedesktop/UDisks2/block_devices/sdc1
neighbor: udisks://by-id-nvme-Samsung_SSD_960_EVO_250GB_S3ESNX0J963065M-part2
name: /org/freedesktop/UDisks2/block_devices/nvme0n1p2
neighbor: udisks://by-id-nvme-Samsung_SSD_960_EVO_250GB_S3ESNX0J963065M-part1
name: /org/freedesktop/UDisks2/block_devices/nvme0n1p1
neighbor: udisks://by-id-dm-name-vg1-var
name: /org/freedesktop/UDisks2/block_devices/dm_2d8
neighbor: udisks://by-id-dm-name-vg1-steam--library
name: /org/freedesktop/UDisks2/block_devices/dm_2d12
neighbor: udisks://by-id-dm-name-vg1-home
name: /org/freedesktop/UDisks2/block_devices/dm_2d4
neighbor: udisks://by-id-dm-name-crypt_volume
name: /org/freedesktop/UDisks2/block_devices/dm_2d14
OK
mount test udisks://by-uuid-4E72-568E/music-test
OK
listmounts
mount: 
mount: test
OK
listfiles
directory: test
OK
listfiles test
directory: boot
Last-Modified: 2013-04-21T16:18:56Z
directory: formulare
Last-Modified: 2019-01-16T15:28:36Z
file: wifi-pw.txt
size: 64
Last-Modified: 2014-12-25T15:12:56Z
file: ._.Trashes
size: 4096
Last-Modified: 2014-12-25T15:13:46Z
directory: EFI
Last-Modified: 2017-12-19T17:20:24Z
directory: music-test
Last-Modified: 2019-02-21T10:10:34Z
directory: .Trash-1000
Last-Modified: 2017-12-08T13:56:52Z
directory: .Trashes
Last-Modified: 2014-12-25T15:13:46Z
directory: .fseventsd
Last-Modified: 2014-12-25T15:13:46Z
directory: .Spotlight-V100
Last-Modified: 2014-12-25T15:13:46Z
file: raspberry.pi.b.plus.pdf
size: 278145
Last-Modified: 2015-12-18T17:50:14Z
file: Windows Schlüssel (MSDNAA)
size: 430
Last-Modified: 2016-02-21T12:25:02Z
OK
MaxKellermann commented 5 years ago

There's a TODO comment for this ;-) https://github.com/MusicPlayerDaemon/MPD/blob/bbaeea1ab7e512531ce846721722b5fc708a22c9/src/storage/plugins/UdisksStorage.cxx#L365