If the directory specified on the 'playlist_directory' setting is inside 'music_directory' setting, but doesn't exit, mpd will error on update of the library

i30817 commented 5 years ago

Bug report

Describe the bug

Expected Behavior

It''s a bit strange because the error doesn't give even a shadow of a clue what's wrong. 'Malformed path'; and i was left thinking of why the midi dir wasn't scanning 'Utf-8 support missing? Broken zip or audio file? ???'. Also maybe it's not recommended to place the playlist dir inside the music dir, but i definitely didn't expect this error to stop the database update cold.

Actual Behavior

A bit user unfriendly.

Version

Music Player Daemon 0.21.4 (0.21.4)

Copyright 2003-2007 Warren Dukes <warren.dukes@gmail.com>
Copyright 2008-2018 Max Kellermann <max.kellermann@gmail.com>
This is free software; see the source for copying conditions.  There is NO
warranty; not even MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Database plugins:
 simple proxy upnp

Storage plugins:
 local smbclient udisks nfs curl

Neighbor plugins:
 smbclient upnp udisks

Decoders plugins:
 [mad] mp3 mp2
 [mpg123] mp3
 [vorbis] ogg oga
 [oggflac] ogg oga
 [flac] flac
 [opus] opus ogg oga
 [sndfile] wav aiff aif au snd paf iff svx sf voc w64 pvf xi htk caf sd2
 [audiofile] wav au aiff aif
 [dsdiff] dff
 [dsf] dsf
 [hybrid_dsd] m4a
 [faad] aac
 [mpcdec] mpc
 [wavpack] wv
 [modplug] 669 amf ams dbm dfm dsm far it med mdl mod mtm mt2 okt s3m stm ult umx xm
 [mikmod] amf dsm far gdm imf it med mod mtm s3m stm stx ult uni xm
 [sidplay] sid mus str prg P00
 [wildmidi] mid
 [fluidsynth] mid
 [adplug] amd d00 hsc laa rad raw sa2
 [ffmpeg] 16sv 3g2 3gp 4xm 8svx aa3 aac ac3 adx afc aif aifc aiff al alaw amr anim apc ape asf atrac au aud avi avm2 avs bap bfi c93 cak cin cmv cpk daud dct divx dts dv dvd dxa eac3 film flac flc fli fll flx flv g726 gsm gxf iss m1v m2v m2t m2ts m4a m4b m4v mad mj2 mjpeg mjpg mka mkv mlp mm mmf mov mp+ mp1 mp2 mp3 mp4 mpc mpeg mpg mpga mpp mpu mve mvi mxf nc nsv nut nuv oga ogm ogv ogx oma ogg omg opus psp pva qcp qt r3d ra ram rl2 rm rmvb roq rpl rvc shn smk snd sol son spx str swf tak tgi tgq tgv thp ts tsp tta xa xvid uv uv2 vb vid vob voc vp6 vmd wav webm wma wmv wsaud wsvga wv wve
 [gme] ay gbs gym hes kss nsf nsfe sap spc vgm vgz
 [pcm]

Filters:
 libsamplerate soxr

Tag plugins:
 id3tag

Output plugins:
 shout null fifo pipe alsa ao oss openal pulse jack httpd recorder

Encoder plugins:
 null vorbis opus lame wave flac

Archive plugins:
 [bz2] bz2
 [zzip] zip
 [iso] iso

Input plugins:
 file archive alsa tidal qobuz curl ffmpeg smbclient nfs mms cdio_paranoia

Playlist plugins:
 extm3u m3u pls xspf asx rss soundcloud flac cue embcue

Protocols:
 file:// alsa:// tidal:// qobuz:// http:// https:// gopher:// rtp:// rtsp:// rtmp:// rtmpt:// rtmps:// smb:// nfs:// mms:// mmsh:// mmst:// mmsu:// cdda://

Other features:
 avahi dbus udisks epoll icu inotify ipv6 systemd tcp un

Log

Jun 23 08:34 : update: added Game Music/Lifeformed - Pillars of Pepper (Fastfall - Dustforce OST).MP3
Jun 23 08:34 : update: added Game Music/Chrono Cross OST - Dreams of the Shore Near Another World.m4a
Jun 23 08:34 : update: added Game Music/Mark Morgan - All-Clear Signal.mp3
Jun 23 08:34 : update: added Game Music/Azrael s Tear soundtrack: Peaceful (JV-1080).mp3
Jun 23 08:34 : client: [6] opened from local
Jun 23 08:34 : player: played "Game Music Mods/Utopia.zip/Utopia-Title.MOD"
Jun 23 08:35 : player: played "Game Music Mods/Utopia.zip/Utopia-InGame1.MOD"
Jun 23 08:35 : exception: Failed to open /media/i30817/Huginn/Music/playlists: No such file or directory
Jun 23 08:35 : client: [5] closed
Jun 23 08:36 : client: [6] closed
Jun 23 08:36 : client: [7] opened from local
Jun 23 08:42 : exception: RTIOThread could not get realtime scheduling, continuing anyway: sched_setscheduler failed: Operation not permitted
Jun 23 08:42 : avahi: Service 'Music Player @ AIVAS' successfully established.
Jun 23 08:42 : client: [0] opened from local
Jun 23 08:42 : exception: Failed to open /media/i30817/Huginn/Music/playlists: No such file or directory
Jun 23 08:42 : client: [1] opened from local
Jun 23 08:42 : exception: Failed to open ZIP file /media/i30817/Huginn/Music/Game Music Mods/Jazz Jackrabbit 3.zip
Jun 23 08:43 : client: [0] closed
Jun 23 08:44 : exception: RTIOThread could not get realtime scheduling, continuing anyway: sched_setscheduler failed: Operation not permitted
Jun 23 08:44 : avahi: Service 'Music Player @ AIVAS' successfully established.
Jun 23 08:44 : client: [0] opened from local
Jun 23 08:44 : client: [1] opened from local
Jun 23 08:44 : exception: Failed to open ZIP file /media/i30817/Huginn/Music/Game Music Mods/Jazz Jackrabbit 3.zip

(there is a lot of failing to open nonexistent the playlist dir near the start too).

i30817 commented 5 years ago

It's possible this is already fixed upstream considering the ancient version on the ubuntu repo.

MaxKellermann commented 5 years ago

It's possible this is already fixed upstream considering the ancient version on the ubuntu repo.

So what now? Do you expect me to spend time on figuring out this part of your problem?

i30817 commented 5 years ago

Considering the repo has no libboost 1.68, which the build config file says is broken, i was planning on waiting until it was updated to build to post more information.

I may not, but i certainly wouldn't if i hadn't opened the bug to remember.

MaxKellermann commented 5 years ago

This bug report is too confusing for me to understand. It cites error messages which I cannot see in the pasted log. It says MPD fails to update, but there is no update error in the log. And since it affects a very outdated MPD version, I decide not to spend time on this. See https://www.musicpd.org/help/

MusicPlayerDaemon / MPD