search

MusicPlayerDaemon / mpc

Command-line client for MPD
GNU General Public License v2.0
191 stars 36 forks source link

Add support for consume: oneshot #109

Closed Mstrodl closed 8 months ago

Mstrodl commented 8 months ago

I think I got all the spots, but let me know if I missed anything!

MaxKellermann commented 8 months ago

This fails to build if you compile with libmpdclient 2.20 or older - mpc should be compatible with older libmpdclient releases (at least 2.18 as documented and specified in meson.build), and thus you need a compile-time check.

Mstrodl commented 8 months ago

Hey, I added version checks consistent with these old ones: https://github.com/MusicPlayerDaemon/mpc/commit/3ec52051b465c8392f6f264a215d03a309d0665b

MaxKellermann commented 8 months ago

The second commit just fixes mistakes in the first commit - this shouldn't be a separate commit, because it is not a separate work. The second commit even re-adds code that the first code deletes, which is confusing for review. Please amend existing commits if you find mistakes instead of adding fixup commits to the same unmerged PR.

Mstrodl commented 8 months ago

I squashed the commits, let me know if you have any other feedback.