Support scrobbling partway through the track instead of only at the end.

MusicPlayerDaemon / mpdscribble

a MPD client which submits information about tracks being played to a scrobbler (e.g. last.fm)

GNU General Public License v2.0

116 stars 15 forks source link

Support scrobbling partway through the track instead of only at the end. #5

Closed jaccarmac closed 4 years ago

jaccarmac commented 6 years ago

Most other scrobblers allow setting a percentage of a track to scrobble at from 51-100%, a set time to scrobble at no matter what (like 4:00), rules to scrobble long tracks multiple times, or a combination of all three. These would be nice features to have for mpdscribble.

MunifTanjim commented 4 years ago

I think it's already there: https://github.com/MusicPlayerDaemon/mpdscribble/blob/048bc62e43a6000f99291522b725f1ddd48864c1/src/Main.cxx#L44-L55

jaccarmac commented 4 years ago

Indeed, and while that particular code is new the function is not. Wonder why I'm only seeing scrobbles happen at track completion?

MunifTanjim commented 4 years ago

Probably one of the two reasons:

The song is not submitted halfway through the duration. It's submitted only after a new song is started (either it has played it's whole duration or you changed the song after playing more than half of it).
You're using an old build.

MaxKellermann commented 4 years ago

Closing, because this is already implemented. And yes, mpdscribble only scrobbles at track completion, i.e. when the track playback ends.