search

Musicoin / desktop

The official Musicoin Desktop Wallet Application
https://musicoin.org
Other
115 stars 67 forks source link

[macOS] [1.0.1] Port conflict with Ethereum wallet #214

Open pcb355 opened 6 years ago

pcb355 commented 6 years ago

The default port for the Musicoin desktop wallet is 8545, which is the same as the Ethereum desktop wallet client, Mist. You can't run both of these wallets at the same time. There is a configuration file that allows the port to be specified, but changing it to another port doesn't work properly. I have searched extensively for a solution to this conflict, and I can't find one.

Seeing that ETH is the second biggest coin by market cap, and I would expect a lot of people storing Musicoin will also be holding ETH, why was the same exact port used? Is there a solution that I'm just not seeing? Is this an issue that is planning on being addressed in the future?

Thanks, any help is appreciated!

Varunram commented 6 years ago

We do agree that people storing Musicoin well also be holding Ether, just that the founders while creating Musicoin didn't expect that people would want to spend both coins at the same time (and still don't). Solution wise, there is no solution in particular since I don't think it is possible to change the port number even with a hard fork, since that'd be creating a new coin in itself. In the event that ALL nodes upgrade to the hard forked version, we might be able to do this, but since there are no guarantees and that it is not feasible to expect everyone to run the same node version, I think such a change will not be accepted.

pcb355 commented 6 years ago

The port number I'm referring to is the internal node.js port number that the Musicoin desktop client uses to communicate with the gmc (Go Musicoin) server implementation. Since the Ether wallet also uses node.js, and also uses port 8545 to communicate with it's geth (Go Ether) server implementation, they have a conflict. I don't believe this is an issue for how the external nodes operate. There is even a config file for all of this to be easily changed, but the source code is using hard coded port numbers of 8545.

Users should be able to simultaneously run and support the wallet of their choice for any cryptocurrency at the same time, IMHO. Most bitcoin derived core wallets (BTC, BCH, BTG, LTC, etc) use a similar mechanism and have configurable internal port number capability. Maybe at this time it's not an important consideration, but if you hope Musicoin to be a widely used crypto, then the user should have a seamless install and working client, even if they have chosen to support other cryptos. The 1.0.1 client doesn't even provide an error message if this conflict occurs it just sits there waiting to connect with no feedback to the user.

cosminstefane commented 6 years ago

Yap, I have the same problem, I am constantly running a full parity node on ETH, it is my choice, I don't want to stop that to use music.