Musicoin / go-musicoin

:link: Go-version of Musicoin blockchain wallet and consensus
GNU Lesser General Public License v3.0
161 stars 57 forks source link

GMC -V3, need to check licenses term. #60

Closed trustfarm-dev closed 7 years ago

trustfarm-dev commented 7 years ago

System information

GMC version: gmc v3.0 OS & Version: Windows/Linux/OSX Commit hash : (if develop)

Expected behaviour

There's need to printing License term , to GPL or LGPL, MIT or Apache, ...

Actual behaviour

run gmcv3 --help NAME: gmcv3 - the go-ethereum command line interface Copyright 2013-2017 The go-ethereum Authors ... VERSION: 2.1.0-unstable-b0f741e8

or gmcv3 license GMC is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.

Steps to reproduce the behaviour

Just built and Run

Recommendation, Add GPL license term to gmcv3 printing.

5chdn commented 7 years ago

There's need to printing License term , to GPL or LGPL, MIT or Apache, ...

Why? It's in the repository in all source files and the readme already. There is a copyright notice at the end of --help.

trustfarm-dev commented 7 years ago

@5chdn I know, also, gmcv3 license shows GPL well. I recommend to sync printing. like parity1.8 way.


Parity version Parity/v1.8.0-unstable-9882902-20171015/x86_64-linux-gnu/rustc1.21.0 Copyright 2015, 2016, 2017 Parity Technologies (UK) Ltd License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html.

5chdn commented 7 years ago

This will get messy because GMC is licensed under two different licenses. The copyright notice is sufficient in my eyes.