Musicoin / go-musicoin

:link: Go-version of Musicoin blockchain wallet and consensus
GNU Lesser General Public License v3.0
162 stars 57 forks source link

2.6.0: Propose replay attack protection hardfork at 2000000, ref #44 #62

Closed 5chdn closed 6 years ago

5chdn commented 6 years ago

Closes #30

Closes #44

Closes #79

Test instructions in #79

trustfarm-dev commented 6 years ago

EIP 158 will no effect on this fork. 158 is remove spam tx (null) tx , when contract gas ddos Oct 2016, in ethereum main chain. make slim and decrease chain size. here musicoin chain no spam tx in main chain, so, it is no-problem, it will on or not. anyway, no problem.

trustfarm-dev commented 6 years ago

And, 1987654 block heights is not a meaning on this time. Many peer nodes needs to update time and tests, before softforks. so, 2M (end of feb) is proper choice of block number. and, many guys easily identifying and remember softfork blocknumber on the view of human.

5chdn commented 6 years ago

Updated block fork number to 2_000_000 and merged #74

Having EIP-158 is a no-brainer, does not hurt :)

trustfarm-dev commented 6 years ago

Go : -)

5chdn commented 6 years ago

Bumps version to 2.6.0 to distinguish the build

5chdn commented 6 years ago

Edit: See #79