search

Musicoin / go-musicoin

:link: Go-version of Musicoin blockchain wallet and consensus
GNU Lesser General Public License v3.0
161 stars 57 forks source link

Provide diff for code verification #75

Closed Varunram closed 6 years ago

Varunram commented 6 years ago

Requests for this have been there for a long time and now that we're incorporating changes from upstream geth, I think it would be better to provide a diff comparing against the latest version of geth so that people can compare stuff and see what parts of the codebase we've changed.

XhmikosR commented 6 years ago

Can't you keep an upstream branch and just make your changes in master/custom or whatever branch?

Varunram commented 6 years ago

Ah, I guess that should be possible. @5chdn what do you think?

5chdn commented 6 years ago

I don't understand what this is about. #57 #66 #67 #69 #77 ?

Varunram commented 6 years ago

I think what XhmikosR meant really was whether we could have a branch with geth (say at branch "upstream") and maintain gmc at say "master" so that viewing diff becomes easier (instead of the PRs themselves)

On 30 January 2018 at 13:35, Afri Schoedon notifications@github.com wrote:

I don't understand what this is about. #57 https://github.com/Musicoin/go-musicoin/pull/57 #66 https://github.com/Musicoin/go-musicoin/pull/66 #67 https://github.com/Musicoin/go-musicoin/pull/67 #69 https://github.com/Musicoin/go-musicoin/pull/69 #77 https://github.com/Musicoin/go-musicoin/pull/77 ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Musicoin/go-musicoin/issues/75#issuecomment-361507354, or mute the thread https://github.com/notifications/unsubscribe-auth/ARvML7RY2yLLGlxzLV5qnUFgqEBcIpl0ks5tPs1dgaJpZM4RwC8u .

XhmikosR commented 6 years ago

Yup, exactly ^^.

5chdn commented 6 years ago

https://github.com/Musicoin/go-musicoin/compare/go-ethereum...master