search

Musicoin / go-musicoin

:link: Go-version of Musicoin blockchain wallet and consensus
GNU Lesser General Public License v3.0
161 stars 57 forks source link

build: fix version comparison for go1.10 and beyond #91

Closed teutat3s closed 6 years ago

teutat3s commented 6 years ago

build process stops without this commit when using latest Go Version (go1.10) on MacOS High Sierra. With this commit all works.

5chdn commented 6 years ago

Thanks, this is a real annoyance. :+1:

etaletai13 commented 6 years ago

That's bizarre. I could swear I JUST posted exactly this. But apparently you did! Hahahah either way at least I know I'm not the kind of crazy that thinks this is an issue erroneously.

5chdn commented 6 years ago

Yes, this was all fixed in #77 and reverted in #87. Now we are cherry-picking issues as we go.

etaletai13 commented 6 years ago

@5chdn Awesome, thanks so much.

etaletai13 commented 6 years ago

It still doesn't build on 1.10.1 without doing a sed s/1.7/1.10/g on build/ci.go

Varunram commented 6 years ago

We're anyway planning to rebase stuff as part of #95, so lets take care of this there.